hg: jdk8/tl/jdk: 8011800: Add java.util.Objects.requireNonNull(T, Supplier<String>)

[Joe Darcy]

On 04/16/2013 09:43 AM, Chris Hegarty wrote:
> On 04/16/2013 05:35 PM, Joe Darcy wrote:
>> Sorry for any inconvenience this has caused, but I'm a bit perplexed
>> this changeset caused a problem for several reasons.
>>
>> First, I did a clean images build on linux with this changeset it all
>> was well. Second, as I understand it, the Supplier type should be in
>> compact1.
>
> If you are using jdk8 as a bootstrap then it will be ok. Maybe this 
> explains why it built ok for you?

No; I use a recent JDK 7 update as the bootstrap.

Langtools does now use methods in Objects, but not this new method.

-Joe

>
> langtools needs to build with jdk7.
>
> -Chris.
>
>>
>> -Joe
>>
>> On 04/16/2013 04:45 AM, Chris Hegarty wrote:
>>> On 04/16/2013 12:02 PM, Alan Bateman wrote:
>>>> On 16/04/2013 11:47, Chris Hegarty wrote:
>>>>>
>>>>> Here is a simple anti-delta patch, under 8012343:
>>>>> "Objects.requireNonNull(Object,Supplier) breaks genstubs build"
>>>>>
>>>>> http://cr.openjdk.java.net/~chegar/8012343/webrev.00/webrev/
>>>>>
>>>>> Once reviewed, I will push it. We can leave it to Joe and Jon to work
>>>>> out the more tricky genstubs issue ;-)
>>>>>
>>>>> -Chris.
>>>> Bootstraping the build is complicated and I'm not 100% sure why a stub
>>>> is generated for java.util.Objects, Jon will know. In the 
>>>> mean-time, the
>>>> patch to anti-delta the change is fine. It's not nice to have to do 
>>>> this
>>>> of course we need to get jdk8/tl building again.
>>>
>>> Pushed
>>>   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61cfbe08ce5d
>>>
>>> Apologies to Joe for the crude backout. On the positive side, now that
>>> jdk8/tl is buildable again, the pressure is off to find a solution for
>>> genstubs.
>>>
>>> -Chris.
>>>
>>>>
>>>> -Alan
>>