RFR: 8004518 & 8010122 : Default methods on Map

[Ulf Zibis]

Am 16.04.2013 20:04, schrieb Mike Duigou:
> On Apr 15 2013, at 16:13 , Ulf Zibis wrote:
>
>> HashTable line 972, 992, 1011, 1035, 1064, 1099, etc. 
> These don't seem to line up with anything in either rev 5 or 6 of Hashtable source (or HashMap).

Oops again, these were numbers from rev. 2.
I see, you have them corrected in rev. 6. :-)
There only remains one in line 477.

>> Oops I'm sorry, I meant lines 976, 1062 of Map. 
> Corrected.

I don't see correction in rev. 6, now lines 982, 1068
Additionally lines 507, 508, 952..960

>> In Collections I've found additional inconsistent indentations, lines 2836, 2837, 2848, 2853, 2897
> Corrected.

I don't see correction in rev. 6, now lines 2838, 2839, 2850, 2855, 2899(also space after casts)

>> Old code: 262, 270, 292, 1248, 1304, 1528, 1580, 1611, 1784, 1873, 1995, 2036, 2092, 2304, 2414, 2460, 2694, 2760, 2770, 2819, 3032, 3071, 3118, 3155, 3164, 3214, 3273, 3318, 3322, 3358, 3397, 3446, 3559, 3633, 3756, 3790, 3809, 3832, 3867, 3965, 4014, 4070, 4109, 4133, 4301, 4381, 4413, 4445.
> I am unwilling to change most of these.

I agree, that's why I've written "old code".

> Thank you for your careful review. You definitely have sharper eyes than most for this kind of problem.

They instantly jump in my eye ;-) I first thought, there were few, but then ... I couldn't resist to 
*play* the full game ;-)

Thanks for your time,

-Ulf