RFR: 8021591 : (s) Additional explicit null checks

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 1 15:57:56 UTC 2013


On 26/07/2013 16:31, Mike Duigou wrote:
> Hello all;
>
> This patch adds some missing checks for null that, according to interface contract, should be throwing NPE. It also improves the existing tests to check for these cases.
>
> http://cr.openjdk.java.net/~mduigou/JDK-8021591/0/webrev/
>
> The changes to src/share/classes/java/util/concurrent/ConcurrentHashMap.java will be synchronized separately with the jsr166 workspace. They are part of this review to avoid test failures.
>
> Mike
As retainAll and removeAll are long standing methods, are there are 
cases where we might now throw NPE when we didn't previously? I'm just 
wondering if any of these need to be looked at more closely, minimally 
to get into release/compatibility notes.

-Alan



More information about the core-libs-dev mailing list