Remove superfluous @test tags from SpliteratorTraversingAndSplittingTest

Chris Hegarty chris.hegarty at oracle.com
Fri Aug 2 10:18:35 UTC 2013


On 02/08/2013 10:52, Paul Sandoz wrote:
>
> On Aug 2, 2013, at 9:59 AM, Chris Hegarty<chris.hegarty at oracle.com>  wrote:
>
>> SpliteratorTraversingAndSplittingTest contains two @test tags. The second of which does not specify that the test needs to run with testng. This causes the test to fail, or have an error, when run as a batch with other tests.
>>
>> The second @test tag is just not needed, and the @bug should be moved to the original @test tag.
>>
> Ooops that is my fault, thanks for sorting this out.

No Problem.

> When i ran jtreg manually it did not barf, is there anyway for it to validate the meta-data?

I also noticed this. Running the test explicitly seems to locate just 
the first @test, while running in a batch (sometimes) finds the two! Not 
sure why. It is also ok to have more than one @test, just in this case 
it would need to specify testng.

-Chris.

> Paul.
>
>>
>> diff -r 29f153e11683 test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java
>> --- a/test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java     Fri Aug 02 08:59:37 2013 +0800
>> +++ b/test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java     Fri Aug 02 09:53:00 2013 +0100
>> @@ -25,6 +25,7 @@
>>   * @test
>>   * @summary Spliterator traversing and splitting tests
>>   * @run testng SpliteratorTraversingAndSplittingTest
>> + * @bug 8020016
>>   */
>>
>> import org.testng.annotations.DataProvider;
>> @@ -81,10 +82,6 @@ import static org.testng.Assert.*;
>> import static org.testng.Assert.*;
>> import static org.testng.Assert.assertEquals;
>>
>> -/**
>> - * @test
>> - * @bug 8020016
>> - */
>> @Test
>> public class SpliteratorTraversingAndSplittingTest {
>>
>> -Chris.
>



More information about the core-libs-dev mailing list