code review request: JDK-8015780: java/lang/reflect/Method/GenericStringTest.java failing

Joseph Darcy joe.darcy at oracle.com
Fri Aug 9 01:38:25 UTC 2013


Hi Vicente,

Looks fine; approved to go back.

Thanks,

-Joe

On 8/6/2013 6:59 AM, Vicente-Arturo Romero-Zaldivar wrote:
> Hello,
>
> Please review this patch, which updates test 
> jdk/test/java/lang/reflect/Method/GenericStringTest.java for it to 
> pass after changes introduced to generation of bridge methods.
>
> Now if a bridge method is generated, all annotations present in the 
> related "standard" method are copied to the bridge method.
>
> Part of the job of this test is to compare the method generic string 
> against the one provided in the ExpectedGenericString annotation. The 
> fix is to add another element to the same annotation in case a bridge 
> method is generated. Later it's needed to determine which element's 
> value we need to compare with.
>
> The webrev is here:
> http://cr.openjdk.java.net/~vromero/8015780/webrev.00/
>
> The bug report is here:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015780
>
> Thanks,
> Vicente.




More information about the core-libs-dev mailing list