RFR lint warnings in j.u.concurrent.**

[Mike Duigou]

Fine from me as well.

On Aug 9 2013, at 09:51 , Joe Darcy wrote:

> Agreed; looks good.
> 
> Thanks,
> 
> -Joe
> 
> On 8/9/2013 8:27 AM, Lance Andersen - Oracle wrote:
>> looks fine chris
>> 
>> Best
>> Lance
>> On Aug 9, 2013, at 11:03 AM, Chris Hegarty wrote:
>> 
>>> These changes address the remaining lint warnings in the j.u.concurrent.** package(s).
>>> 
>>> The changes are already in the JSR166 CVS, this is a request to bring them into jdk8.
>>> 
>>> diff -r 84004d0e3fdd src/share/classes/java/util/concurrent/CompletableFuture.java
>>> --- a/src/share/classes/java/util/concurrent/CompletableFuture.java Fri Aug 09 13:50:13 2013 +0100
>>> +++ b/src/share/classes/java/util/concurrent/CompletableFuture.java Fri Aug 09 15:58:41 2013 +0100
>>> @@ -420,6 +420,7 @@ public class CompletableFuture<T> implem
>>>     }
>>> 
>>>     /** Base class can act as either FJ or plain Runnable */
>>> +    @SuppressWarnings("serial")
>>>     abstract static class Async extends ForkJoinTask<Void>
>>>         implements Runnable, AsynchronousCompletionTask {
>>>         public final Void getRawResult() { return null; }
>>> @@ -671,6 +672,7 @@ public class CompletableFuture<T> implem
>>>     }
>>> 
>>>     // Opportunistically subclass AtomicInteger to use compareAndSet to claim.
>>> +    @SuppressWarnings("serial")
>>>     abstract static class Completion extends AtomicInteger implements Runnable {
>>>     }
>>> 
>>> diff -r 84004d0e3fdd src/share/classes/java/util/concurrent/ConcurrentHashMap.java
>>> --- a/src/share/classes/java/util/concurrent/ConcurrentHashMap.java Fri Aug 09 13:50:13 2013 +0100
>>> +++ b/src/share/classes/java/util/concurrent/ConcurrentHashMap.java Fri Aug 09 15:58:41 2013 +0100
>>> @@ -4716,6 +4716,7 @@ public class ConcurrentHashMap<K,V> exte
>>>      * Base class for bulk tasks. Repeats some fields and code from
>>>      * class Traverser, because we need to subclass CountedCompleter.
>>>      */
>>> +    @SuppressWarnings("serial")
>>>     abstract static class BulkTask<K,V,R> extends CountedCompleter<R> {
>>>         Node<K,V>[] tab;        // same as Traverser
>>>         Node<K,V> next;
>>> diff -r 84004d0e3fdd src/share/classes/java/util/concurrent/atomic/Striped64.java
>>> --- a/src/share/classes/java/util/concurrent/atomic/Striped64.java Fri Aug 09 13:50:13 2013 +0100
>>> +++ b/src/share/classes/java/util/concurrent/atomic/Striped64.java Fri Aug 09 15:58:41 2013 +0100
>>> @@ -43,6 +43,7 @@ import java.util.concurrent.ThreadLocalR
>>>  * for classes supporting dynamic striping on 64bit values. The class
>>>  * extends Number so that concrete subclasses must publicly do so.
>>>  */
>>> + at SuppressWarnings("serial")
>>> abstract class Striped64 extends Number {
>>>     /*
>>>      * This class maintains a lazily-initialized table of atomically
>>> 
>>> 
>>> -Chris.
>> 
>> 
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
>> 
>