Please review java.util.formatter bug fix

Xueming Shen xueming.shen at oracle.com
Tue Aug 13 20:16:12 UTC 2013


Looks fine.

Since you have already turned the verbose off and reduced the locales, it
might be worth still letting it run N=12. The original idea with 12 is that
it increases the chance of running into daylight saving on and off cases.

-Sherman

On 08/13/2013 12:06 PM, roger riggs wrote:
> Hi,
>
> The tests for java.util.Formatter were failing in the th_TH locale.
> The test incorrectly relied on the locale defined calendar instantiation.
> Java.util.formatter should be using YEAR_OF_ERA to extract the year
> to get consistent results with the Japanese Calendar, for the other
> calendars it does not change the values.
> The tests are extended to explicitly test the Gregorian, Japanese, and
> ThaiBuddist calendar formatting using both the Java.util.Calendar and
> ChronoZonedDateTime calendars.
>
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-fixed-locale-8022193/
>
> Thanks, Roger
>




More information about the core-libs-dev mailing list