RFR 8023150 java/util/stream tests no longer compiling following JDK-8019401

Paul Sandoz paul.sandoz at oracle.com
Fri Aug 16 10:27:21 UTC 2013


Hi,

This patch fixes a compilation failure in the stream-based tests:

diff -r 5649837a4cfa test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java
--- a/test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java	Mon Aug 12 12:06:50 2013 -0400
+++ b/test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java	Fri Aug 16 12:13:18 2013 +0200
@@ -609,7 +609,7 @@
     @Test(dataProvider = "StreamTestData<Integer>", dataProviderClass = StreamTestDataProvider.class)
     public void testComposeFinisher(String name, TestData.OfRef<Integer> data) throws ReflectiveOperationException {
         List<Integer> asList = exerciseTerminalOps(data, s -> s.collect(toList()));
-        List<Integer> asImmutableList = exerciseTerminalOps(data, s -> s.collect(collectingAndThen(toList(), Collections::unmodifiableList)));
+        List<Integer> asImmutableList = exerciseTerminalOps(data, s -> s.collect(collectingAndThen(toList(), Collections::<Integer>unmodifiableList)));
         assertEquals(asList, asImmutableList);
         try {
             asImmutableList.add(0);


This test is the same (without the above patch applied) in the lambda repo and the code compiles without error. I suspect this is due to differences between javac behaviour in both repos.

Paul.


More information about the core-libs-dev mailing list