RFR: JDK-8023203 - Wrap RandomAccessFile.seek native method into a Java helper method

Chris Hegarty chris.hegarty at oracle.com
Mon Aug 19 08:58:16 UTC 2013


On 19/08/2013 09:35, Alan Bateman wrote:
> On 19/08/2013 01:44, Dan Xu wrote:
>> HiAll,
>>
>> Please review the simple change for JDK-8023203 - Wrap
>> RandomAccessFile.seek native method into a Java helper method. Itadds
>> a helper java method and makes it the only place that can invoke the
>> native method directly. Thanks!
>>
>> Webrev: http://cr.openjdk.java.net/~dxu/8023203/webrev/
>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8023203
> I don't think we have a bug here but as a defensive change then it's
 > okay
+1

> (the duplicate check isn't a concern as a lseek is relatively
> expensive).

Trivially, I'd remove the extra native check, but I can understand why 
you may want to keep it.

-Chris.

>
> -Alan



More information about the core-libs-dev mailing list