8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile

[Mike Duigou]

Looks very good!

On Aug 20 2013, at 05:13 , Alan Bateman wrote:

> 
> For some time now we have been chipping away at the make files that are used to run the jdk tests. Mike has his wielded his axe on several occasions recently to remove logic and rules that are no longer needed. One of the next steps needs to be to remove the definitions of the test targets from the make file as it can't currently be shared between the Makefile and direct jtreg usage.

I'm eager to wield the axe again once this is change is integrated to remove the directory specifications from the test/Makefile (and hopefully soon from jprt.properties as well). :-)

> To that end, I'd like to push a TEST.groups file to define the corresponding jtreg groups. For the most part the proposal is to start up with a mostly 1-1 mapping for the existing test targets.

Once we have A/B runs that show the same tests are run we can consider refactoring the organization. (For example, I would like to see at least a portion of sun/misc move from jdk_lang to jdk_util).

> In addition to groups for the normal test target then I also propose to add higher level groups that partition the entire test suite into three groups named "core", "svc" and "desktop". This makes it really easy to run selections of the test suite, for example "jtreg <options> :core :svc" will run all the core area and serviceability tests.
> 
> One other thing to mention is that David Holmes will arrive soon with additional groups to add selection of tests that are appropriate for the compact Profiles, maybe JRE vs. JDK too.
> 
> The webrev with the proposed changes is here, it's very simple:
> 
> http://cr.openjdk.java.net/~alanb/8023351/webrev/
> 
> A few things to note (as there are a few small changes from the normal test targets):
> 
> 1. I've moved the management and java.lang.instrument tests out of the jdk_lang group. Once the make file targets are updated then these can be re-included if needed but logically they should be separated.
> 
> 2. I have not moved the JSR-292 tests or stream tests, they remain in jdk_lang and jdk_util for now. They can easily be changed if there is good reason.

Probably they will get their own sub-groups but may or may not remain in the super-groups.

> 3. I've kept security1, security2 and security3 for now but these are unbalanced in execution time and ideally should all be in one group. Once we get to the point that concurrency is dialed up by default then that might be the right time to do that.

I am glad to see you defined the jdk_security super-group. This allows us to abstract these details. 

> 4. To my knowledge, the client teams do not use the make files and I don't know anyone that used the jdk_awt, etc. make targets. For now, I've just re-worked those targets (eliminating the beans1, beans2, beans3 that have not been needed since we moved the execution mode out of the make file). I'm sure someone in the AWT or 2D area could come up with cleaner definitions but as they aren't used then it shouldn't matter for now.
> 
> -Alan
> 
>