RFR: JDK-8023430 - Replace File.mkdirs with Files.createDirectories to get MaxPathLength.java failure details

Dan Xu dan.xu at oracle.com
Wed Aug 21 21:06:14 UTC 2013


On 08/20/2013 11:18 PM, Alan Bateman wrote:
> On 21/08/2013 01:04, Dan Xu wrote:
>> Hi,
>>
>> MaxPathLength.java testcase failed intermittently. And File.mkdirs() 
>> does not throw any exceptions when it fails, which makes it even 
>> harder for the diagnosis. As Alan suggested, I'd like to change it to 
>> Files.createDirectories to get detailed exceptions once a failure 
>> happens. Thanks!
>>
>> webrev: http://cr.openjdk.java.net/~dxu/8023430/webrev/
>> bug: http://bugs.sun.com/view_bug.do?bug_id=8023430
> I think this is the right thing to do to find out what is going on. 
> With the patch then you can remove couldMakeTestDirectory as the 
> exists check and throwing the exception is no longer needed.
>
> -Alan.

Thanks, Alan. I have updated my webrev at, 
http://cr.openjdk.java.net/~dxu/8023430/webrev.01/. Please take a look!

-Dan



More information about the core-libs-dev mailing list