Please review fix for 8011944 : Sort fails with ArrayIndexOutOfBoundsException

Alan Bateman Alan.Bateman at oracle.com
Fri Aug 23 14:56:44 UTC 2013


On 22/08/2013 15:25, roger riggs wrote:
> Please review the fix for:
>
>   JDK-8011944[1] : Sort fails with ArrayIndexOutOfBoundsException
>
> The pending run stack size is estimated based on the input size.
> The worst case sequence of inputs exceeds the current allocation and 
> an exception occurs.
> Increasing the allocation of the pending run stack addresses the issue.
> This was present in the original contribution of Timsort and 
> ComparableTimSort.
>
> Webrev[2]:
>   http://cr.openjdk.java.net/~rriggs/webrev-timsort-8011944/
Increasing the size of the merge stack looks right. Do you know if there 
is potential for other cases that could cause problems?

-Alan



More information about the core-libs-dev mailing list