RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

[Aleksey Shipilev]

Reminder :)

-Aleksey.

On 08/23/2013 02:38 PM, Aleksey Shipilev wrote:
> Hm, I think I still need the second reviewer.
> Anyone?
> 
>   http://cr.openjdk.java.net/~shade/8023234/webrev.01/
> 
> -Aleksey.
> 
> On 08/21/2013 11:05 PM, Aleksey Shipilev wrote:
>> Thanks Martin!
>>
>> I need a sponsor to push this.
>>
>> -Aleksey.
>>
>> P.S. The support for multi-threaded tests in jtreg/library is one of the
>> things I'm eager to have.
>>
>> On 08/21/2013 10:53 PM, Martin Buchholz wrote:
>>> OK, approved!
>>>
>>> I would do things differently, and there is the deeper problem that
>>> openjdk provides no test infrastructure for multi-threaded tests, which
>>> we are suffering from here.  Now that testng is being used, it's a good
>>> time for someone to import test infrastructure from JSR166TestCase
>>>
>>>
>>> On Wed, Aug 21, 2013 at 10:46 AM, Aleksey Shipilev
>>> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
>>>
>>>     Hi Martin,
>>>
>>>     On 08/21/2013 06:28 AM, Martin Buchholz wrote:
>>>     > If a Reader throws, the test might still pass, since only throwing
>>>     from
>>>     > the main thread matters.  See infrastructure in JSR166TestCase, e.g.
>>>     > threadUnexpectedException.
>>>
>>>     Yes. I still don't think there is a value in catching the exceptions in
>>>     the threads for this concrete regression test. Should the reader die
>>>     with the exception, the test will fail anyway, since enough readers are
>>>     not available.
>>>
>>>     > OTOH, there seems no value in converting exceptions in the main thread
>>>     > to ISE.  Just declare main to throw Exception or whatever.
>>>
>>>     This seems to be the stylistic nit. ;) There is the symmetry against
>>>     readers code, which wraps the exceptions into the ISE. For my taste, it
>>>     looks better to retain that symmetry.
>>>
>>>     I can still make the changes to the test, if you insist.
>>>
>>>     -Aleksey.
>>>
>>>
>>
>