RFR: JDK-4792059 -- test/java/io/pathNames/GeneralSolaris.java fails on symbolic links
Alan Bateman
Alan.Bateman at oracle.com
Wed Aug 28 11:05:17 UTC 2013
On 28/08/2013 00:20, Dan Xu wrote:
> Hi,
>
> When GeneralSolaris testcase follows symbolic link to pick up an
> existing file or directory for testing, it will fail the assertion in
> check()method because the file path canonicalization process will
> result in the real path not a path containing symbolic link. I enforce
> this test not to use any symbolic link as a testing file ordirectory
> to avoid this problem. Please help review my fix. Thanks!
>
> bug: https://bugs.openjdk.java.net/browse/JDK-4792059
> webrev: http://cr.openjdk.java.net/~dxu/4792059/webrev/
>
> -Dan
You can drop the exists check as Files.isXXXX can't return true if the
file doesn't exist. Otherwise looks okay to me.
-Alan.
More information about the core-libs-dev
mailing list