JDK 8 RFR of javax.script doclint fixes

roger riggs roger.riggs at oracle.com
Tue Dec 3 17:57:01 UTC 2013


Hi,

Not specific to your change, but the previous sentences end in ";" in 
some cases and ":" in others.
I thing ":" colon is more natural.

Roger

On 12/3/2013 12:55 PM, roger riggs wrote:
> Hi Joe,
>
> looks fine,
>
> Not a reviewer, Roger
>
> On 12/3/2013 12:49 PM, Joe Darcy wrote:
>> Hello,
>>
>> Please review the patch before which addresses a handful of doclint 
>> issues in javax.script.
>>
>> Thanks,
>>
>> -Joe
>>
>> diff -r c11553506228 
>> src/share/classes/javax/script/ScriptEngineFactory.java
>> --- a/src/share/classes/javax/script/ScriptEngineFactory.java Tue Dec 
>> 03 08:53:23 2013 +0100
>> +++ b/src/share/classes/javax/script/ScriptEngineFactory.java Tue Dec 
>> 03 09:48:11 2013 -0800
>> @@ -144,7 +144,7 @@
>>       * Returns a String which can be used to invoke a method of a 
>> Java object using the syntax
>>       * of the supported scripting language.  For instance, an 
>> implementation for a Javascript
>>       * engine might be;
>> -     * <p>
>> +     *
>>       * <pre>{@code
>>       * public String getMethodCallSyntax(String obj,
>>       *                                   String m, String... args) {
>> @@ -180,7 +180,7 @@
>>       * Returns a String that can be used as a statement to display 
>> the specified String  using
>>       * the syntax of the supported scripting language.  For 
>> instance, the implementation for a Perl
>>       * engine might be;
>> -     * <p>
>> +     *
>>       * <pre><code>
>>       * public String getOutputStatement(String toDisplay) {
>>       *      return "print(" + toDisplay + ")";
>> @@ -198,7 +198,7 @@
>>      /**
>>       * Returns a valid scripting language executable program with 
>> given statements.
>>       * For instance an implementation for a PHP engine might be:
>> -     * <p>
>> +     *
>>       * <pre>{@code
>>       * public String getProgram(String... statements) {
>>       *      String retval = "<?\n";
>>
>




More information about the core-libs-dev mailing list