JDK 8 RFR 8029514: java/math/BigInteger/BigIntegerTest.java failing since thresholds adjusted in 8022181

Joseph Darcy joe.darcy at oracle.com
Thu Dec 5 00:18:57 UTC 2013


Hi Brian,

I've taken a look at the change, but I don't understand why the problem 
wasn't surfaced before?

-Joe

On 12/4/2013 1:34 PM, Brian Burkhalter wrote:
> Hello,
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8029514
> Webrev:	http://cr.openjdk.java.net/~bpb/8029514/webrev/
>
> The problem causing this failure is that the method getLower() used by Karatsuba multiplication is expected to return an unsigned value but instead returns 'this' if the parameter 'n' is not greater than the int-length of the BigInteger on which it is invoked. For multiplications in which there is a negative factor this could result in an incorrect product being obtained.
>
> The BigIntegerTest is also updated to reflect the modified thresholds (should have been in the patch for 8022181 but was not …).
>
> Thanks,
>
> Brian




More information about the core-libs-dev mailing list