RFR: 8029451 : Tidy warnings cleanup for java.util package

Paul Sandoz paul.sandoz at oracle.com
Thu Dec 5 11:22:58 UTC 2013


On Dec 5, 2013, at 6:30 AM, Sergey Lugovoy <sergey.lugovoy at oracle.com> wrote:

> Hi all,
> please review the fix
> http://cr.openjdk.java.net/~yan/8029451/webrev.01/
> for
> https://bugs.openjdk.java.net/browse/JDK-8029451
> 
> This patch cleanup tidy warnings for generated html documentation, and do
> not affect the appearance of the documentation.
> 

The following:

--- old/src/share/classes/java/util/ArrayList.java	2013-12-04 17:00:04.849173427 +0000
+++ new/src/share/classes/java/util/ArrayList.java	2013-12-04 17:00:04.657173433 +0000
@@ -70,9 +70,9 @@
  * unsynchronized access to the list:<pre>
  *   List list = Collections.synchronizedList(new ArrayList(...));</pre>
  *
- * <p><a name="fail-fast">
+ * <p><a name="fail-fast"> </a>
  * The iterators returned by this class's {@link #iterator() iterator} and
- * {@link #listIterator(int) listIterator} methods are <em>fail-fast</em>:</a>
+ * {@link #listIterator(int) listIterator} methods are <em>fail-fast</em>:
  * if the list is structurally modified at any time after the iterator is
  * created, in any way except through the iterator's own
  * {@link ListIterator#remove() remove} or

effectively reverts:

  http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94e1a4b10811
  http://hg.openjdk.java.net/jdk8/tl/jdk/diff/94e1a4b10811/src/share/classes/java/util/ArrayList.java

Any reason for that? and similar changes to Vector. I don't know whether the addition of text content that is a space perturbs the formatting.


--- old/src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java	2013-12-04 17:00:07.793173340 +0000
+++ new/src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java	2013-12-04 17:00:07.637173345 +0000
@@ -80,7 +80,7 @@
  * {@link ReadLock#tryLock()} and {@link WriteLock#tryLock()} methods
  * do not honor this fair setting and will immediately acquire the lock
  * if it is possible, regardless of waiting threads.)
- * <p>
+ * </p>
  * </dl>

Just remove <p> instead of replacing?

Paul.


More information about the core-libs-dev mailing list