RFR for JDK-7168267: TEST_BUG: Cleanup of rmi regression tests (activation and others)

[Tristan Yan]

/Hi everyone
I am working on bug JDK-7168267 
<https://bugs.openjdk.java.net/browse/JDK-6963118> .

Root Cause:
- Per Stuart's comment, this is a clean up bug.

Suggested Fix:
- Will use timeout to replace loop.
- Also I am fixing two test's performance
java/rmi/activation/Activatable/forceLogSnapshot - method waitAllStarted 
is using sleep to poll 50 restartedObject to be true, we can use modern 
CountDownLatch to implement blocking-time wait.
java/rmi/activation/Activatable/checkAnnotations - We can subclass 
ByteArrayOutputStream which support notification when data was written. 
Also use two thread wait output string and error string to be not null.

Please let me know if you have any comments or suggestions.
/ /
Thank you
Tristan

On 12/05/2013 09:02 AM, Stuart Marks wrote:
/
> /On 12/3/13 11:05 PM, Tristan Yan wrote:
> /
>> /I am working on https://bugs.openjdk.java.net/browse/JDK-7168267. 
>> This bug is
>> asking performance improvement for RMI test. Because this would involve
>> different RMI tests. I’d like to use this cr as an umbrella bug, 
>> create sub-cr
>> for different test. Then I can make progress on sub-cr. Please let me 
>> know your
>> opinion on this.
>> /
> /
> Actually JDK-7168267 is more about various test cleanups, and 
> JDK-8005436 is more about performance. Both bugs, though, make general 
> statements about "the RMI tests" and don't have much information about 
> specific actions that need to be taken. I've added some notes to 
> JDK-7168267 about some cleanups that could be done.
> / /
> If there are specific actions for either of these bugs, then yes, 
> creating Sub-Tasks of these bugs and fixing them individually is the 
> right thing to do.
> / /
> s'marks
> / 
/
/