FYI, regression test exclusion as temporary part of JDK_MINOR_VERSION increment for JDK 9

Chris Hegarty chris.hegarty at oracle.com
Thu Dec 19 09:05:27 UTC 2013


Looks good to me Joe.

This change, to me at least, demonstrates the power of the ProblemList.txt. It is a really useful mechanism.

-Chris.

On 19 Dec 2013, at 07:59, Joe Darcy <joe.darcy at oracle.com> wrote:

> Hello,
> 
> Already out for review on the build-dev list is a change to increment JDK_MINOR_VERSION from 8 to 9 as part of getting JDK 9 underway. However, due to HotSpot bug
> 
>    JDK-8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
> 
> (also out for review) a number of jdk and langtools regression tests fail after the increment. As shown in the patch below, my proposed change for incrementing JDK_MINOR_VERSION includes excluding (in one way or another) a number of regression tests in the jdk and langtools repositories. Since langtools doesn't have a problem list file, I'm proposing to @ignore the tests until the HotSpot but is fixed.
> 
> Thanks,
> 
> -Joe
> 
> --- old/common/autoconf/version-numbers    2013-12-18 09:12:06.000000000 -0800
> +++ new/common/autoconf/version-numbers    2013-12-18 09:12:06.000000000 -0800
> @@ -24,7 +24,7 @@
> #
> 
> JDK_MAJOR_VERSION=1
> -JDK_MINOR_VERSION=8
> +JDK_MINOR_VERSION=9
> JDK_MICRO_VERSION=0
> JDK_UPDATE_VERSION=
> LAUNCHER_NAME=openjdk
> --- old/langtools/test/tools/javac/MethodParameters/AnnotationTest.java 2013-12-18 09:12:07.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/AnnotationTest.java 2013-12-18 09:12:07.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters AnnotationTest.java
> --- old/langtools/test/tools/javac/MethodParameters/AnonymousClass.java 2013-12-18 09:12:07.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/AnonymousClass.java 2013-12-18 09:12:07.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters AnonymousClass.java
> --- old/langtools/test/tools/javac/MethodParameters/CaptureTest.java 2013-12-18 09:12:07.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/CaptureTest.java 2013-12-18 09:12:07.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8015701
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary Test method parameter attribute generation with captured locals.
>  * @compile -parameters CaptureTest.java
>  * @run main CaptureTest
> --- old/langtools/test/tools/javac/MethodParameters/Constructors.java 2013-12-18 09:12:08.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/Constructors.java 2013-12-18 09:12:08.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters Constructors.java
> --- old/langtools/test/tools/javac/MethodParameters/EnumTest.java 2013-12-18 09:12:08.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/EnumTest.java 2013-12-18 09:12:08.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582 8008658
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters EnumTest.java
> --- old/langtools/test/tools/javac/MethodParameters/InstanceMethods.java 2013-12-18 09:12:09.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/InstanceMethods.java 2013-12-18 09:12:09.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters InstanceMethods.java
> --- old/langtools/test/tools/javac/MethodParameters/LambdaTest.java 2013-12-18 09:12:09.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/LambdaTest.java 2013-12-18 09:12:09.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters LambdaTest.java
> --- old/langtools/test/tools/javac/MethodParameters/LocalClassTest.java 2013-12-18 09:12:09.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/LocalClassTest.java 2013-12-18 09:12:09.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582 8008658
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters LocalClassTest.java
> --- old/langtools/test/tools/javac/MethodParameters/MemberClassTest.java 2013-12-18 09:12:10.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/MemberClassTest.java 2013-12-18 09:12:10.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582 8008658
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters MemberClassTest.java
> --- old/langtools/test/tools/javac/MethodParameters/StaticMethods.java 2013-12-18 09:12:10.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/StaticMethods.java 2013-12-18 09:12:10.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters StaticMethods.java
> --- old/langtools/test/tools/javac/MethodParameters/UncommonParamNames.java 2013-12-18 09:12:10.000000000 -0800
> +++ new/langtools/test/tools/javac/MethodParameters/UncommonParamNames.java 2013-12-18 09:12:10.000000000 -0800
> @@ -24,6 +24,7 @@
> /*
>  * @test
>  * @bug 8006582
> + * @ignore 8030656 Bad version check for parameter information in src/share/vm/classfile/javaClasses.cpp
>  * @summary javac should generate method parameters correctly.
>  * @build Tester
>  * @compile -parameters UncommonParamNames.java
> --- old/jdk/test/ProblemList.txt    2013-12-18 09:12:11.000000000 -0800
> +++ new/jdk/test/ProblemList.txt    2013-12-18 09:12:11.000000000 -0800
> @@ -123,6 +123,11 @@
> # 8029415
> java/lang/reflect/Method/invoke/TestPrivateInterfaceMethodReflect.java generic-all
> 
> +# 8030656
> +java/lang/reflect/Parameter/GetAnnotatedTypeTest.java generic-all
> +java/lang/reflect/Parameter/WithParameters.java generic-all
> +java/lang/reflect/Parameter/BadClassFiles.java generic-all
> +
> ############################################################################
> 
> # jdk_management
> 




More information about the core-libs-dev mailing list