Code review request for 8007113 Upgrade AnnotatedElement.isAnnotionPresent to be a default method

Chris Hegarty chris.hegarty at oracle.com
Fri Feb 1 07:08:48 UTC 2013


Joe,

This looks good to me Joe, and I like that the default method spells out 
its implementation.

Out of curiosity, strictly speaking is this considered a specification 
change? Since the public override methods no longer exist in the 
concrete classes.

-Chris.

On 02/01/2013 03:21 AM, Joe Darcy wrote:
> Hello,
>
> I'd like to upgrade the existing AnnotatedElement.isAnnotationPresent
> interface method to a default method:
>
>      8007113 Upgrade AnnotatedElement.isAnnotionPresent to be a default
> method
>      http://cr.openjdk.java.net/~darcy/8007113.0/
>
> This ends up removing several copies of the same logic in the JDK; all
> reflection and annotations regression test pass with this change.
>
> Thanks,
>
> -Joe



More information about the core-libs-dev mailing list