RFR JDK-8007609
David Holmes
david.holmes at oracle.com
Wed Feb 6 09:51:29 UTC 2013
Hi John,
On 6/02/2013 9:49 AM, John Zavgren wrote:
> Greetings:
>
> I modified the code in
> src/windows/native/java/io/WinNTFileSystem_md.c
> so that it checks the return value of realloc() and frees memory when there is an error.
>
> The webrev image of this change is visible at:
> http://cr.openjdk.java.net/~jzavgren/8007609/webrev.01/
The style in that file is all over the place but unless it involves the
actual fix it is better to leave it as is - else it just obscures the
real change.
The core of the fix seems okay.
This change:
! if (cp != NULL)
! {
was correct in its previous form:
if (cp != NULL) {
Also the indentation seems very wrong at:
len = (*GetFinalPathNameByHandle_func)(h, result, len, 0);
Cheers,
David
> Thanks!
> John Zavgren
More information about the core-libs-dev
mailing list