JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Tue Feb 19 07:28:15 UTC 2013


Looks good to me.

Masayoshi

On 2/19/2013 3:58 PM, Joe Darcy wrote:
> Hello,
>
> Please review these two simple fixes for javadoc warnings I noticed 
> during a build (I'll file a bug after getting a review):
>
> diff -r bcde0486261e 
> src/share/classes/java/time/format/DateTimeFormatterBuilder.java
> --- a/src/share/classes/java/time/format/DateTimeFormatterBuilder.java 
> Mon Feb 18 08:14:18 2013 +0000
> +++ b/src/share/classes/java/time/format/DateTimeFormatterBuilder.java 
> Mon Feb 18 22:55:56 2013 -0800
> @@ -1007,7 +1007,7 @@
>       * is used, with {@code IsoChronology} as the fallback.
>       * <p>
>       * Note that this method provides similar functionality to 
> methods on
> -     * {@code DateFormat} such as {@link 
> DateFormat#getDateTimeInstance(int, int)}.
> +     * {@code DateFormat} such as {@link 
> java.text.DateFormat#getDateTimeInstance(int, int)}.
>       *
>       * @param dateStyle  the date style to use, null means no date 
> required
>       * @param timeStyle  the time style to use, null means no time 
> required
> diff -r bcde0486261e src/share/classes/java/util/TimeZone.java
> --- a/src/share/classes/java/util/TimeZone.java    Mon Feb 18 08:14:18 
> 2013 +0000
> +++ b/src/share/classes/java/util/TimeZone.java    Mon Feb 18 22:55:56 
> 2013 -0800
> @@ -534,7 +534,7 @@
>      /**
>       * Gets the {@code TimeZone} for the given {@code zoneId}.
>       *
> -     * @param zoneid a {@link ZoneId} from which the time zone ID is 
> obtained
> +     * @param zoneId a {@link ZoneId} from which the time zone ID is 
> obtained
>       * @return the specified {@code TimeZone}, or the GMT zone if the 
> given ID
>       *         cannot be understood.
>       * @throws NullPointerException if {@code zoneId} is {@code null}
>
> Thanks,
>
> -Joe




More information about the core-libs-dev mailing list