RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

Yekaterina Kantserova yekaterina.kantserova at oracle.com
Wed Feb 20 09:26:06 UTC 2013


On 02/19/2013 05:01 PM, Alan Bateman wrote:
> On 13/02/2013 09:47, Yekaterina Kantserova wrote:
>> Hi everyone,
>>
>> This small fixconcerns jdk.testlibrary.JdkFinder utility class. The 
>> check below is too OS dependent and should be deleted.
>> ...
>>         binPath += File.separatorChar + "bin" + File.separatorChar + 
>> executable;
>>         File toolFile = new File(binPath);
>> ==> if (!toolFile.exists()) {
>>             throw new RuntimeException(binPath + " does not exist");
>>         }
>> ...
>>
>> On windows if executable is specified as e.g. 'java', without '.exe', 
>> the File exists() will fail. But it's still possible to run executable.
Thanks for reviewing this! Yes, Staffan Larsen helped me last time, I 
hope he can do it again.

// Katja
> This looks okay to me, do you have someone to push this for you?
>
> -Alan.




More information about the core-libs-dev mailing list