RFR: 8005545: Add System property to identify ARCH specific details such as ARM hard-float binaries

Bob Vandette bob.vandette at oracle.com
Thu Feb 21 22:23:45 UTC 2013


Looks good to me other than the variable name.

I'd prefer JDK_ARCH_ABI_NAME or JDK_ARCH_ABI_PROP_NAME over ARCHABIPROPNAME.


Bob.


On Feb 21, 2013, at 5:02 PM, Vladimir Danushevsky wrote:

> Please review changes for https://jbs.oracle.com/bugs/browse/JDK-8005545  "Add System property to identify ARCH specific details such as ARM hard-float binaries" which adds an optional sun.os.abi Java system property indicating an ABI type being used by the JVM:
> 
> CCC Reguest: http://ccc.us.oracle.com/8005545
> 
> Webrev:
> http://cr.openjdk.java.net/~vladidan/8005545/webrev.00/
> 
> Separate change to the build script (e.g. in ARM Hard-Float ABI case):
> setenv ARCHABIPROPNAME gnueabihf
> -DARCHABIPROPNAME="\"$(ARCHABIPROPNAME)\""  is passed to the CFLAGS
> 
> Thanks,
> Vlad




More information about the core-libs-dev mailing list