Withdraw: Review: 4396272 - Parsing doubles fails to follow IEEE for largest decimal that should yield 0
Brian Burkhalter
brian.burkhalter at oracle.com
Fri Feb 22 20:31:13 UTC 2013
Dima,
Great! Thanks. I will take a look later and re-post the review.
Brian
On Feb 22, 2013, at 12:29 PM, Dmitry Nadezhin wrote:
> Brian,
>
> I removed unused methods and fields from FormattedFloatingDecimal.
> JDK build passes.
> The result of "hg diff" is attached.
>
> -Dima
>
> On Fri, Feb 22, 2013 at 9:49 PM, Brian Burkhalter
> <brian.burkhalter at oracle.com> wrote:
>> Dima,
>>
>> If the methods are definitely unused that would be correct. I suppose if a
>> clean build of the JDK does not complain then it is acceptable and correct.
>>
>> Thanks,
>>
>> Brian
>>
>> On Feb 22, 2013, at 9:41 AM, Dmitry Nadezhin wrote:
>>
>> So I think that the required change in FormattedFloatingDecimal is to
>> delete methods
>> doubleValue(), floatValue() and other unused methods and fields. Am I right
>> ?
>>
>>
> <hgdiff.txt>
More information about the core-libs-dev
mailing list