RFR: 8005545: Add System property to identify ARCH specific details such as ARM hard-float binaries
Vladimir Danushevsky
vladimir.danushevsky at oracle.com
Fri Feb 22 21:33:39 UTC 2013
Thanks, webrev updated
http://cr.openjdk.java.net/~vladidan/8005545/webrev.01/
On Feb 22, 2013, at 5:57 AM, Alan Bateman wrote:
> On 21/02/2013 22:02, Vladimir Danushevsky wrote:
>> :
>>
>> Webrev:
>> http://cr.openjdk.java.net/~vladidan/8005545/webrev.00/ <http://cr.openjdk.java.net/%7Evladidan/8005545/webrev.00/>
>>
>> Separate change to the build script (e.g. in ARM Hard-Float ABI case):
>> setenv ARCHABIPROPNAME gnueabihf
>> -DARCHABIPROPNAME="\"$(ARCHABIPROPNAME)\"" is passed to the CFLAGS
>>
> I agree with Bob on the naming, otherwise it looks okay to me.
>
> On the release file and Images.gmk then jdk/tl was sync'ed up yesterday so you will probably need to re-base the patch.
>
> -Alan
More information about the core-libs-dev
mailing list