RFR: javax.xml.stream: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)

Mandy Chung mandy.chung at oracle.com
Wed Jan 9 23:24:11 UTC 2013


On 1/9/2013 1:13 PM, Daniel Fuchs wrote:
> Hi Mandy,
>
> Please find clarifications in line:
>
> On 1/9/13 9:30 PM, Mandy Chung wrote:
>>
>>    Since there is a behavioral change, the following statements are 
>> not true
>> any more and I think they can be removed.
>>
>>  166    * No changes in behavior are defined by this replacement 
>> method relative
>>  167    * to the deprecated method.
> The behavior change is the same in both the deprecated & the new 
> method - since
> it occurred in the FactoryFinder which both methods are calling, so I
> think this statement is still true.

I interpreted it differently comparing the old implementation of the 
deprecated newInstance method with the new implementation of newFactory 
method. My interpretation may be wrong and so will leave it to Joe to 
comment.  I'm fine with what you currently have.

>>
>> The classLoader parameter passed to the newFactory(String, 
>> ClassLoader) method
>> is actually ignored.  It might be good to clarify that since the spec 
>> is updated
>> anyway.
>
> I think it's a bug. I'm intending to log it as a separate issue. FWIW 
> in the other factories
> (in other packages) the classloader is not ignored.

In that case, please file a bug to track this.

Thanks
Mandy



More information about the core-libs-dev mailing list