Request for review: 8005618 - TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently

David Holmes david.holmes at oracle.com
Tue Jan 15 01:31:38 UTC 2013


On 15/01/2013 7:12 AM, Rob McKenna wrote:
> Simple enough fix but to be honest I'm not sure any value will *always*
> work for the dead process waitFor(). Our testing infrastructure seems to
> glide past whatever we consider to be acceptable tolerances.
>
> http://cr.openjdk.java.net/~robm/8005618/webrev.01/
> <http://cr.openjdk.java.net/%7Erobm/8005618/webrev.01/>

Using the latch seems reasonable but the existing wait/sleep times do 
not. Why waitFor(10000) if the main thread is going to interrupt you 
after a sleep(1000) ???

David

> -Rob



More information about the core-libs-dev mailing list