RFR: 8006090 - Formatter asserts with -esa

Xueming Shen xueming.shen at oracle.com
Thu Jan 17 18:10:03 UTC 2013


On 1/17/13 10:00 AM, Alan Bateman wrote:
>
> This looks fine to me.
>
> Sherman - I suspect the same assert in the print method added by 
> JSR-310 has the same issue.

Yes. That will be removed as well.

>
> -Alan.
>
> On 17/01/2013 17:36, Brian Burkhalter wrote:
>> The assert occurs in
>>
>> private Appendable print(StringBuilder sb, Calendar t, char c,
>>                                   Locale l)
>>
>> due to
>>
>> assert(width == -1);
>>
>> not being satisfied. The proposed fix is to remove this assert 
>> statement which appears to be vestigial. Regression and compatibility 
>> testing did not reveal any failures due to removing this statement.
>>
>> --- old/src/share/classes/java/util/Formatter.java 2013-01-16 
>> 12:22:55.000000000 -0800
>> +++ new/src/share/classes/java/util/Formatter.java 2013-01-16 
>> 12:22:55.000000000 -0800
>> @@ -3827,7 +3827,6 @@
>>                                    Locale l)
>>               throws IOException
>>           {
>> -            assert(width == -1);
>>               if (sb == null)
>>                   sb = new StringBuilder();
>>               switch © {
>>
>> Thanks,
>>
>> Brian
>




More information about the core-libs-dev mailing list