RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

Rob McKenna rob.mckenna at oracle.com
Fri Jan 25 20:43:38 UTC 2013


Yup, all affected tests pass in both jprt and via an ssh session to a mac.

     -Rob

On 25/01/13 16:07, Alexey Utkin wrote:
> Looks good. Did you test the fix in ssh session to Mac?
> -uta
>
> On 25.01.2013 19:37, Rob McKenna wrote:
>> Had a chat with Alexey off list. Since 7162111 is indeed required to 
>> get these tests running on headless systems we've agreed to go ahead 
>> with this fix. (but not 8004928) A webrev with this change is at:
>>
>> http://cr.openjdk.java.net/~robm/7162111/webrev.02/ 
>> <http://cr.openjdk.java.net/%7Erobm/7162111/webrev.02/>
>>
>>     -Rob
>>
>>
>> On 20/12/12 22:11, Stuart Marks wrote:
>>> On 12/19/12 12:32 AM, Alan Bateman wrote:
>>>> On 17/12/2012 18:46, Rob McKenna wrote:
>>>>> Hi folks,
>>>>>
>>>>> This review contains:
>>>>>
>>>>> 8003898: X11 toolkit can be chosen as the default toolkit
>>>>> 7162111: TEST_BUG: change tests run in headless mode [macosx] (open)
>>>>> 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT 
>>>>> subsystem
>>>>>
>>>>> Unfortunately the last two patches didn't apply cleanly, hence the 
>>>>> review
>>>>> request. (the commit comments will be altered appropriately before 
>>>>> integration)
>>>>>
>>>>> Webrev at:
>>>>>
>>>>> http://cr.openjdk.java.net/~robm/7162111/webrev.01/
>>>>> <http://cr.openjdk.java.net/%7Erobm/7162111/webrev.01/>
>>>> 8003898 is important to get into jdk7u, but I don't think 7162111 
>>>> or 8004928 is
>>>> really needed there.
>>>
>>> Isn't 7162111 important to avoid hangs/failures when running the 
>>> tests on the Mac? Plus it removes tests from the problem list so we 
>>> get better test coverage in 7u.
>>>
>>> s'marks
>>
>




More information about the core-libs-dev mailing list