8005697: Add StampedLock - JEP 155

Chris Hegarty chris.hegarty at oracle.com
Tue Jan 29 10:57:40 UTC 2013


On 01/29/2013 12:01 AM, Doug Lea wrote:
> On 01/28/13 06:32, Chris Hegarty wrote:
>> As part of JEP 155 (Concurrency Updates) we are proposing to add
>> StampedLock. A
>> capability-based lock with three modes for controlling read/write access.
>>
>> Javadoc:
>>
>> http://cr.openjdk.java.net/~chegar/8005697/ver.00/javadoc/StampedLock.html
>>
>>   (some external links are not working in this online version)
>>
>> Webrev:
>>    http://cr.openjdk.java.net/~chegar/8005697/ver.00/webrev/webrev/
>>
>
> Martin Buchholz pointed out a javadoc warning.

I missed these warnings as they were to javadoc on private members. 
Quite trivially, the commented assert added with these fixes is missing 
a trailing ';'.
   // assert (s & ABITS) >= RFULL

> I also noticed that I had failed to include the simple
> toString-based informal debug/monitoring aids that we've
> been doing for synchronizers. Sorry. Now added.
> For example, printing a lock twice during a test:
> java.util.concurrent.locks.StampedLock at 29178281[Read-locks:13]
> ...
> java.util.concurrent.locks.StampedLock at 29178281[Unlocked]

Ah yes, this is nice, and consistent. It effects the API, so I will 
regenerate the javadoc.

Martin made another good suggestion. I will regenerate the 
webrev/javadoc after you give this some consideration.

-Chris.

>
> -Doug
>
>
>
>



More information about the core-libs-dev mailing list