Codereview request for 8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64 character
Xueming Shen
xueming.shen at oracle.com
Thu Jan 31 21:07:10 UTC 2013
Thanks! webrev has been updated accordingly.
-Sherman
On 01/31/2013 01:01 PM, Alan Bateman wrote:
> On 31/01/2013 20:23, Xueming Shen wrote:
>> Hi,
>>
>> Please help review changes for
>>
>> 8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64 character
>> 8006526: Base64.Decoder.decode(String) spec contains a copy-paste mistake
>>
>> http://cr.openjdk.java.net/~sherman/8007298_8006526/webrev
> This looks fine to me.
>
> I guess I probably would have done if (IsMIME & (base64[0] == -1) .. but no big deal.
>
> Will you add 8007298 to the list of bugs in the test before you push?
>
> -Alan.
More information about the core-libs-dev
mailing list