RFR: 8017463: [TEST_BUG] 2 tests from tools/pack200/ remain about 1 GB of data in work directory after execution

Mandy Chung mandy.chung at oracle.com
Mon Jul 1 18:14:04 UTC 2013


On 6/29/13 7:02 PM, Kumar Srinivasan wrote:
> Hi,
>
> Please review changes to cleanup the test area after pack200 test
> completion. Some tests generally use large jars and a local copy of 
> the JDK to
> test with, created a generic utility to nuke most of the remains.
>
> The webrev:
> http://cr.openjdk.java.net/~ksrini/8017463/webrev.0/
>

In Utils.cleanup, it will delete the files with certain extensions in 
the current directory.  I skimmed on the tests and look to me that those 
files can be altered with a different path and not necessary in the 
current directory.  Just wonder if you want to make cleanup to take a 
path parameter instead of hardcoding the cwd. Otherwise, this change 
looks fine with me.

Mandy

> The bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017463
>
> Thanks
> Kumar
>




More information about the core-libs-dev mailing list