RFR (2nd): 8017231: Add StringJoiner.merge

Henry Jen henry.jen at oracle.com
Wed Jul 3 21:10:01 UTC 2013


Yes, when I looked at it, there are other places as well. But I decided to leave those alone as for delimiter/prefix/suffix, 'supplied' seems to be fine and consistent.

add() is perhaps a good change. I updated the webrev with this simple change, then I'll need a sponsor to push for me.

Cheers,
Henry


On Jul 3, 2013, at 1:36 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 03/07/2013 20:46, Henry Jen wrote:
>> Hi,
>> 
>> Adapted comments from Alan and Paul, thanks for reviewing.
>> 
>> http://cr.openjdk.java.net/~henryjen/ccc/8017231.1/webrev/
>> 
> This looks good to me.
> 
> (I see you took the suggestion to s/supplied/given. There's another one in the add(CharSequence) method that could be changed too).
> 
> -Alan




More information about the core-libs-dev mailing list