RFR: JAXP 1.5 for JDK8/7u40: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown

[Alan Bateman]

On 04/07/2013 10:11, huizhe wang wrote:
>
> Daniel has helped adding many tests. The 1st one of the two scenarios 
> above are tested. It appeared that the properties set through the 
> factory or parser are always taken into account the last, therefore 
> take preference in consistence with the spec.  We still have the 2nd 
> scenario to test. But here's the latest webrev:
>
>  http://cr.openjdk.java.net/~joehw/jdk8/8016648/webrev/
>
> It also uses the SourceVersion Joe suggested to determine the version 
> of the JDK.

We can't have a dependency on SourceVersion here as it would cause 
problems for modules. I assume it will also break the profiles build 
because the javax.lang.model API is not in compact1 or compact2. So I 
think this need to be reverted to just look at the java.version property 
and I would suggest keeping it simple -- ie: assume the long standing 
format as that cannot be changed without causing wide-spread breakage.

I skimmed over the rest of the webrev and don't see any other issues. 
It's great to hear that Daniel is helping to add tests as that is key to 
having confidence with these changes.

-Alan.