RFR: (JAXP) 8020430 : NullPointerException in xml sqe nightly result on 2013-07-12

[huizhe wang]

Thanks Chris!

On 7/12/2013 10:59 AM, Chris Hegarty wrote:
> On 12 Jul 2013, at 18:09, huizhe wang <huizhe.wang at oracle.com> wrote:
>
>> On 7/12/2013 3:30 AM, Lance Andersen - Oracle wrote:
>>> The fix looks fine to me Joe as does the test.  I assume you will go with Chris's plan below for the test locations?
>> It will be jdk/test/javax/xml/jaxp, that is the location for all jaxp tests for now.  We will look into migrating jaxp tests to the jaxp repo.
>>
> Sounds good to me.
>
> -Chris
>
>> Thanks,
>> Joe
>>
>>> Best
>>> Lance
>>> On Jul 12, 2013, at 5:44 AM, Chris Hegarty wrote:
>>>
>>>> The source changes look fine to me.
>>>>
>>>> The tests should be located elsewhere, otherwise they will collide with an Oracle internal repo. Say jdk/test/jaxp?
>>>>
>>>> As an aside, I plan to move the jaxws tests to a similar holding area, jdk/test/jaxws. They can then follow the appropriate package structure.
>>>>
>>>> -Chris
>>>>
>>>> On 12 Jul 2013, at 09:59, huizhe wang <huizhe.wang at oracle.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> This is a quick fix on a regression caused by 8016648.  The new property manager added to handle the new jaxp 1.5 properties is only created for the input and event factories. For the output factory therefore, there should have a null-check.  I've run the tests used in the nightly build with a local build, all passed with this patch.
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~joehw/jdk8/8020430/webrev/
>>>>>
>>>>> Thanks,
>>>>> Joe
>>>
>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com