RFR 7122142 : (ann) Race condition between isAnnotationPresent and getAnnotations

Aleksey Shipilev aleksey.shipilev at oracle.com
Mon Jul 15 09:04:14 UTC 2013

Hi, Peter,

Not a reviewer, and have barely any time to have the careful review, so
just a few nitpicks below:

On 07/09/2013 12:54 AM, Peter Levart wrote:
> http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/webrev.05/

 - Do you want make contains() generic?
      static <T> boolean contains(T[] array, T element);
 - Also, you might probably put the null-check in contains(), and
simplify the usage
 - parseAnnotation2 seems a bad name; it seems just overloading
parseAnnotation is good.


More information about the core-libs-dev mailing list