Java 8 RFR 8014319: Faster division of large integers

[Brian Burkhalter]

Hi Tim,

Thanks for pointing these out. The SIZE error is mine: overzealous use of "replace all."

I am inclined to fold these updates into this subsequent patch

http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/019009.html

as it is simpler.

Brian

On Jul 17, 2013, at 1:53 PM, Tim Buktu wrote:

> I noticed a couple of minor things.
> In MutableBigInteger, I made an error in the javadoc where it says
> 
> +     * Has the same effect as {@code addend.leftShift(32*ints); add(b);}
> +     * but doesn't change the value of {@code b}.
> 
> when it should be
> 
> +     * Has the same effect as {@code addend.leftShift(32*ints); add(addend);}
> +     * but doesn't change the value of {@code addend}.
> 
> 
> In BigIntegerTest, I think SIZEd should probably be lower case:
> 
> + * throw in boundary numbers such as 0, 1, maximum SIZEd, etc.
> 
> +     * a lot of numbers that will find failure points, such as max SIZEd