RFR: 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermitently

Daniel Fuchs daniel.fuchs at oracle.com
Tue Jul 23 16:32:56 UTC 2013


On 7/23/13 6:07 PM, Mandy Chung wrote:
> On 7/23/2013 9:08 PM, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find below a changeset for fixing
>> 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java
>> is failing intermittently [1]
>>
>> This appears to be a test bug due to a bizarre use of synchronization
>> in the test. The test was failing regularly before the fix (= often
>> enough), but I haven't managed to reproduce since I changed
>> lr.wait() into lr.join();
>>
>> http://cr.openjdk.java.net/~dfuchs/webrev_8019948/webrev.00/
>
> Looks okay.   All traces have this call:
>
>     newDate(System.currentTimeMillis())
>
> Maybe simply move System.currentTimeMillis() to the newDate method
> instead of calling it in the parameter.

Right. Will do - and maybe rename newDate() into getTimeStamp()
while I'm at it. I should have cleaned it up before sending the
review...

Thanks Mandy!

-- daniel

>
> Mandy




More information about the core-libs-dev mailing list