RFR doclint issues in java.net

Joe Darcy joe.darcy at oracle.com
Thu Jul 25 16:13:19 UTC 2013


FWIW, I've filed a bug against doclint to allow ordered lists of the 
form <ol = a>

     JDK-8021324 [doclint] Doclint need not warn over use of ordered 
lists with styles

In any case, the changes below look fine to go back; if you want to 
leave the <ol = a> in java.net, that would be fine by me too.

Thanks,

-Joe

On 07/25/2013 03:16 AM, Lance Andersen - Oracle wrote:
> Good to go
> On Jul 25, 2013, at 6:00 AM, Chris Hegarty wrote:
>
>> This is a request for review for some doclint warnings in the java.net package. Trivially, the list type should be left to the CSS.
>>
>> Note: with these changes there are still warnings for two DatagramPacket constructors that are missing @throws for SocketException. I do not see any reason that these constructors need to throw SE, and I will file a separate bug to follow up.
>>
>> diff -r fd1b5adcfdf0 src/share/classes/java/net/URI.java
>> --- a/src/share/classes/java/net/URI.java       Wed Jul 24 22:52:01 2013 +0100
>> +++ b/src/share/classes/java/net/URI.java       Thu Jul 25 10:56:25 2013 +0100
>> @@ -530,7 +530,7 @@ public final class URI
>>       * href="http://www.ietf.org/rfc/rfc2396.txt">RFC 2396</a>,
>>       * Appendix A, <b><i>except for the following deviations:</i></b> </p>
>>       *
>> -     * <ul type=disc>
>> +     * <ul>
>>       *
>>       *   <li><p> An empty authority component is permitted as long as it is
>>       *   followed by a non-empty path, a query component, or a fragment
>> @@ -993,7 +993,7 @@ public final class URI
>>       *   <li><p> Otherwise the new URI's authority component is copied from
>>       *   this URI, and its path is computed as follows: </p>
>>       *
>> -     *   <ol type=a>
>> +     *   <ol>
>>       *
>>       *     <li><p> If the given URI's path is absolute then the new URI's path
>>       *     is taken from the given URI. </p></li>
>> @@ -1241,7 +1241,7 @@ public final class URI
>>       * <p> The host component of a URI, if defined, will have one of the
>>       * following forms: </p>
>>       *
>> -     * <ul type=disc>
>> +     * <ul>
>>       *
>>       *   <li><p> A domain name consisting of one or more <i>labels</i>
>>       *   separated by period characters (<tt>'.'</tt>), optionally followed by
>> @@ -1495,7 +1495,7 @@ public final class URI
>>       *
>>       * <p> The ordering of URIs is defined as follows: </p>
>>       *
>> -     * <ul type=disc>
>> +     * <ul>
>>       *
>>       *   <li><p> Two URIs with different schemes are ordered according the
>>       *   ordering of their schemes, without regard to case. </p></li>
>> @@ -1513,7 +1513,7 @@ public final class URI
>>       *   <li><p> Two hierarchical URIs with identical schemes are ordered
>>       *   according to the ordering of their authority components: </p>
>>       *
>> -     *   <ul type=disc>
>> +     *   <ul>
>>       *
>>       *     <li><p> If both authority components are server-based then the URIs
>>       *     are ordered according to their user-information components; if these
>>
>>
>> -Chris.
>
>
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
>




More information about the core-libs-dev mailing list