Still need a review for Java 8 RFR 8014319: Faster division of large integers

Brian Burkhalter brian.burkhalter at oracle.com
Fri Jul 26 23:21:19 UTC 2013


On Jul 26, 2013, at 2:54 PM, Martin Buchholz wrote:

> Reluctant math reviewer here.
> 
> Looks good,

Thanks!

> except for apparently overzealous s/size/SIZE/g, as in 
> 
> -     * a lot of numbers that will find failure points, such as max sized
> +     * a lot of numbers that will find failure points, such as max SIZEd

Similar verbiage to my own:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/019035.html

It will be fixed in the 8020641 patch as noted.

Brian

> On Thu, Jul 25, 2013 at 11:55 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> JDK 8 Reviewers:
> 
> This patch is still pending approval by:
> 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-July/018922.html
> 
> Thanks,
> 
> Brian
> 




More information about the core-libs-dev mailing list