8016218: Warnings building corba repo due to missing hashCode methods

Daniel Fuchs daniel.fuchs at oracle.com
Mon Jun 10 15:42:34 UTC 2013

On 6/10/13 1:11 PM, Alan Bateman wrote:
> The warnings from the build of the corba repository on missing hashCode
> methods have been annoying me for some time. I was hoping they would
> annoy others too but looks like I blinked first :-)
> Here's the webrev with the changes that I'd like to push to fix the issues:
> http://cr.openjdk.java.net/~alanb/8016218/webrev/
> Note that there are 3 real issues but they are obvious. I'm running the
> CORBA tests to make sure that it doesn't break anything. Note that the
> bulk of the warnings were coming from ParserTable but they turn out not
> to be interesting because they are only used in the testing framework.
> -Alan.

Hi Alan,

Your changes look good to me.

In ParserTable.java, I wonder whether it would be worth
returning a different constant for each different class.

best regards,

-- daniel

More information about the core-libs-dev mailing list