RFR (jaxp): 8016153 : Property http://javax.xml.XMLConstants/property/accessExternalDTD is not recognized.

[huizhe wang]

Thanks!

On 6/10/2013 12:28 PM, Lance Andersen - Oracle wrote:
> looks OK
> On Jun 10, 2013, at 3:26 PM, huizhe wang wrote:
>
>> Thanks Lance!
>>
>> As Daniel noted, I added warnings to these additional property 
>> settings, but there are a couple of other places in the original JAXP 
>> 1.5 impl that did not have warning. I've added the warning message 
>> now (in ValidatorHandlerImpl.java and XMLReaderManager.java). Also, 
>> in ValidatorHandlerImpl.java, there was a redundant setting at line 
>> 677 that would invalidate a 3rd party impl. This was a porting error 
>> when the patch was ported from jaxp standalone[1] to JDK.  It is now 
>> removed.
>>
>> webrev:
>> http://cr.openjdk.java.net/~joehw/jdk8/8016153/webrev/
>>
>> [1] jaxp standalone source
>> https://java.net/projects/jaxp-sources/sources/svn/content/trunk/xml-xerces/java/src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java?rev=3134
>>
>> Thanks,
>> Joe
>>
>> On 6/10/2013 9:44 AM, Lance Andersen - Oracle wrote:
>>> looks fine joe
>>>
>>> -lance
>>> On Jun 8, 2013, at 4:11 PM, huizhe wang wrote:
>>>
>>>> Hi,
>>>>
>>>> This patch is to continue the support of plugging in 3rd party parser impls (such as Xerces) that do not support JAXP 1.5. The fix is to catch SAXNotRecognizedException, print out a warning, and then continue as usual. The warning is for the developer in case he actually sets the new access* properties on the TransformerFactory but has a 3rd party parser on the classpath that does not support the new properties.
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~joehw/jdk8/8016153/webrev/
>>>>
>>>> I intend to backport the change to 7u.  The change will be identical.
>>>>
>>>> Thanks,
>>>> Joe
>>>
>>>
>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>