RFR 8010325 : Remove hash32() method and hash32 int field from java.lang.String

Alan Bateman Alan.Bateman at oracle.com
Wed Jun 12 09:01:10 UTC 2013


On 11/06/2013 21:32, Brent Christian wrote:
> Hi,
>
> Please review my fix for 8010325.  Some background:
>
> The alternative string-hashing implementation[1] added to 
> java.lang.String a new public method, hash32(), as well as a new 
> private int field to cache the alternate hash value.
>
> Following 8005698 [2] and 8005704 [3], the new method and field in 
> String are no longer used.
>
> By updating a couple lines in Hashtable/HashMap/WeakHashMap, the 
> internal sun.misc.Hashing class can also be removed.
>
> The webrev is here:
> http://cr.openjdk.java.net/~bchristi/8010325/webrev.00/
This looks good to me (and nice to have the footprint of String reduced).

-Alan



More information about the core-libs-dev mailing list