RFR (S) CR 7177472: JSR292: MethodType interning penalizes scalability

Christian Thalinger christian.thalinger at oracle.com
Thu Jun 13 17:51:40 UTC 2013


On Jun 11, 2013, at 7:16 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On Jun 11, 2013, at 2:21 PM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
>> On 06/11/2013 10:24 PM, Christian Thalinger wrote:
>>> 
>>> On Jun 11, 2013, at 9:08 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>> 
>>>> On 06/11/2013 08:06 PM, Christian Thalinger wrote:
>>>>> Anyway, let's push this.
>>>> 
>>>> Do you want me any other testing done? vm.mlvm.testlist is OK, but I
>>>> haven't done the full JPRT test cycle, only the build one.
>>> 
>>> You could do a full Nashorn 262 run.  That would shake out bugs.
>> 
>> Done. Linux x86_64/release passes test262parallel with either clean or
>> patched build.
> 
> Thanks for verifying.  I'll push your change tomorrow.

While preparing the push I noticed the new code gives a warning:

src/share/classes/java/lang/invoke/MethodType.java:1106: warning: [unchecked] unchecked cast
                T that = ((WeakEntry<T>) obj).get();
                                         ^
  required: WeakEntry<T>
  found:    Object
  where T is a type-variable:
    T extends Object declared in class WeakEntry
1 warning

Could you fix that, please?

-- Chris

> 
> -- Chris
> 
>> 
>> -Aleksey.
>> 
> 




More information about the core-libs-dev mailing list