RFR (S) CR 8016236: Class.getGenericInterfaces performance improvement

Alan Bateman Alan.Bateman at oracle.com
Sun Jun 16 19:44:17 UTC 2013


On 13/06/2013 12:47, Aleksey Shipilev wrote:
> Friendly reminder for the reviewers.
>
> On 06/10/2013 07:53 PM, Aleksey Shipilev wrote:
>> This is the follow-up on the issue Doug identified:
>>    http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017798.html
>>
>> I had reworked the patch, webrev is here:
>>    http://cr.openjdk.java.net/~shade/8016236/webrev.01/
> The current webrev is here:
>    http://cr.openjdk.java.net/~shade/8016236/webrev.02/
>
I'm just catching up on this thread, webrev.02 looks very good to me. I 
can sponsor it.

One comment on ClassRepositoryHolder is that it's "yet another class" 
(we have a proliferation of holder classes since we started using this 
idiom). It makes me wonder if it might be better to move the constant to 
ClassRepository.

-Alan.





More information about the core-libs-dev mailing list