RFR 4641897: Faster string conversion of large integers
Alan Bateman
Alan.Bateman at oracle.com
Fri Jun 21 09:49:22 UTC 2013
On 19/06/2013 20:58, Brian Burkhalter wrote:
> Continuing on from this thread
>
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018181.html
>
> here is a new Request for Review, this time for
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4641897
>
> The webrev is here
>
> http://cr.openjdk.java.net/~bpb/4641897/
>
> The code changes have been reviewed by me and regression tests have been run on my development machine including the updated test which is in the webrev. Performance testing has been performed only insofar as to verify improvement at bit lengths much larger than the algorithm crossover threshold with the understanding that, as for 4837946 and 4646474, the threshold is subject to adjustment pending performance evaluation on a mix of platforms.
>
> Thanks,
>
> Brian
One part that might need attention is getRadixConversionCache as I could
imagine cases where the synchronization could lead to contention. Have
you (or Alan) considered alternatives that would limit the
synchronization to only when the powers cache needs to be expanded?
-Alan.
More information about the core-libs-dev
mailing list