Review request for JDK-8016760: failure of regression test langtools/tools/javac/T6725036.java

Xueming Shen xueming.shen at oracle.com
Tue Jun 25 17:50:21 UTC 2013


This is fine to be a workaround for the test case for now. It probably will need to be
undo-ed after the propose change for #8015666 get integrated.

http://cr.openjdk.java.net/~sherman/8015666/webrev/

The proposal for #8015666 is to keep the "existing" behavior of ZipEntry.getTime()
to return a LastModifiedTime converted from the zip entry's ms-dos-formatted date/time
field by using the "default" timezone. A new pair ZipEntry.get/setLastModifiedTime()
will be added to access the "real" UTC time stored in the zip entry, if presents.

The API doc will be updated accordingly as well to explicitly explain the source of the
date/time and the its timezone sensitive conversion.

-Sherman

On 06/25/2013 07:03 AM, Eric McCorkle wrote:
> Hello,
>
> Please review this simple patch which updates regression test
> langtools/tools/javac/T6725036.java to offset the time returned by
> JavaFileObject.getLastModified() with the local time to UTC delta.
>
> Please note that this patch is intended to address the test failures,
> and that I will be immediately opening a new bug to investigate and
> address deeper issues, and also to properly document the API.
>
> The webrev is here:
> http://cr.openjdk.java.net/~emc/8016760/
>
> The bug report is here:
> http://bugs.sun.com/view_bug.do?bug_id=8016760
>
> Thanks,
> Eric




More information about the core-libs-dev mailing list