Review request for JDK-8016760: failure of regression test langtools/tools/javac/T6725036.java

Eric McCorkle eric.mccorkle at oracle.com
Thu Jun 27 21:37:30 UTC 2013


Ok.  I will put it through shortly.

On 06/27/13 14:18, Jonathan Gibbons wrote:
> Yes,
> 
> Per the latest conventions, the line should be of the form
> 
> @ignore  BUGID: synopsis
> 
> where BUGID is the number for a currently open issue that justifies this
> test being ignored.
> 
> -- Jon
> 
> On 06/27/2013 10:31 AM, Eric McCorkle wrote:
>> I could easily replace the patch I have now with one that just marks the
>> test @ignore and commit it.  Do we want to go ahead and approve that?
>>
>> On 06/27/13 13:12, Jonathan Gibbons wrote:
>>> Yes, I think that this is the correct approach.
>>>
>>> -- Jon
>>>
>>>
>>> On 06/27/2013 09:43 AM, Kumar Srinivasan wrote:
>>>> If this is to be undone after the correct zip fix, why not add the
>>>> @ignore for now ?
>>>> and enable this when 8015666 is fixed correctly.
>>>>
>>>> Kumar
>>>>
>>>>> This is fine to be a workaround for the test case for now. It
>>>>> probably will need to be
>>>>> undo-ed after the propose change for #8015666 get integrated.
>>>>>
>>>>> http://cr.openjdk.java.net/~sherman/8015666/webrev/
>>>>>
>>>>> The proposal for #8015666 is to keep the "existing" behavior of
>>>>> ZipEntry.getTime()
>>>>> to return a LastModifiedTime converted from the zip entry's
>>>>> ms-dos-formatted date/time
>>>>> field by using the "default" timezone. A new pair
>>>>> ZipEntry.get/setLastModifiedTime()
>>>>> will be added to access the "real" UTC time stored in the zip entry,
>>>>> if presents.
>>>>>
>>>>> The API doc will be updated accordingly as well to explicitly explain
>>>>> the source of the
>>>>> date/time and the its timezone sensitive conversion.
>>>>>
>>>>> -Sherman
>>>>>
>>>>> On 06/25/2013 07:03 AM, Eric McCorkle wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review this simple patch which updates regression test
>>>>>> langtools/tools/javac/T6725036.java to offset the time returned by
>>>>>> JavaFileObject.getLastModified() with the local time to UTC delta.
>>>>>>
>>>>>> Please note that this patch is intended to address the test failures,
>>>>>> and that I will be immediately opening a new bug to investigate and
>>>>>> address deeper issues, and also to properly document the API.
>>>>>>
>>>>>> The webrev is here:
>>>>>> http://cr.openjdk.java.net/~emc/8016760/
>>>>>>
>>>>>> The bug report is here:
>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8016760
>>>>>>
>>>>>> Thanks,
>>>>>> Eric
> 


More information about the core-libs-dev mailing list