Review Request: BigInteger patch for efficient multiplication and division (#4837946)

Brian Burkhalter brian.burkhalter at oracle.com
Tue Mar 5 16:18:44 UTC 2013


Hi Alan,

On Mar 4, 2013, at 11:40 PM, Alan Eliasen wrote:

>   There are issues filed about the inefficient algorithms used in
> toString and pow:
> 
> 4641897: BigInteger.toString() algorithm slow for large numbers
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4641897
> 
> 4646474: BigInteger.pow() algorithm slow in 1.4.0
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646474

I am aware of these and as of now they are actually on my list to look into after the major Karatsuba patch.

>   Unfortunately, because of the destruction of all the user-submitted
> fixes in bug reports (when are those coming back?) you can't see the
> further comments about these.

There are a couple of comments from you in these two reports. Unfortunately there are not any comprehensive patches in the reports.

As to things gone missing, I am not entirely aware of the transition trajectory from the old system, but I would imagine some things will become visible again once the newer bug system is made public.

> You have my much faster pow() routines in
> Tim Buktu's combined patch for BigInteger, I believe, and you should be
> able to close the latter bug if you merge that entire patch.

OK - good.

> My way
> faster toString patch is not included in that combined patch.

For this then an issue should be filed. If the patch cannot be attached to the issue, it could be posted to this mailing list once the issue number is known.

Thanks,

Brian


More information about the core-libs-dev mailing list